Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialization order breaking registerFilter in customjs #524

Open
1 of 2 tasks
KCMertens opened this issue Aug 19, 2024 · 0 comments
Open
1 of 2 tasks

Fix initialization order breaking registerFilter in customjs #524

KCMertens opened this issue Aug 19, 2024 · 0 comments

Comments

@KCMertens
Copy link
Member

KCMertens commented Aug 19, 2024

If you want to use the insertBefore property, the other filters need to be registered. But that happens only after the corpus data has loaded.
In the previous frontend there was a callback you could register, but they were removed.

  • As a stop-gap reintroduce these so old scripts don't suddenly break.
  • For the next major/vue 3 we should probably migrate to the system Jan has set up where everything is a callback.
@KCMertens KCMertens added the bug label Aug 19, 2024
KCMertens added a commit that referenced this issue Aug 19, 2024
See Fix initialization order breaking registerFilter in customjs #524
KCMertens added a commit that referenced this issue Aug 19, 2024
See Fix initialization order breaking registerFilter in customjs #524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant