Store relation info with index => always return attribute values in results #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline tags used to be indexed and searched case- and accent-sensitively, but we've changed this so it defaults to insensitive instead. This seems to be the more common use case. Set indexing.relationsSensitive to true in blacklab[-server].yaml to keep the old behaviour, where tags where always case-sensitive. This setting is BlackLab-wide; there is no way to e.g. configure this per index.
Because we can now either index relations/tags sensitively or insensitively, we have to make sure we select the correct version. Also, just rely on the _relation's sensitivity settings to desensitize while searching, so we deal correctly with the way the index was created.
jan-niestadt
changed the title
In this case, relationId is set to -1, which is recognized as meaning "there's no extra relation info, don't bother looking". Mostly saves some space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to store relation info, so results can always include span attributes, even if we didn't search for attributes (so the "simple" term was matched, not the term that includes the attributes).