-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest SSSOM(v0.4.x) #681
Conversation
Thanks! Looks sane, so far! |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
==========================================
+ Coverage 76.48% 76.49% +0.01%
==========================================
Files 252 252
Lines 29385 29387 +2
==========================================
+ Hits 22474 22480 +6
+ Misses 6911 6907 -4 ☔ View full report in Codecov by Sentry. |
Apparently I did, sorry about that. Should have been mentioned in mapping-commons/sssom-py#441 |
Duplication of effort with #666 . Closing for that reason. |
It was - see mapping-commons/sssom-py#441 (comment) |
sssom
,semsimian
andkgcl-schema
dependencylinkml
dependency in tox for pytestsssom==0.4.0
is released.Refactors done:
=>from sssom.context import get_default_metadata
from sssom.constants import get_default_metadata
=>from sssom.typehints import Metadata
from sssom.constants import MetadataType
Metadata
had themetadata
attribute which is now collapsedmeta: Metadata
meta: MetadataType
doc = MappingSetDocument(prefix_map=metadata[PREFIX_MAP_KEY], mapping_set=mset)
=>metadata = get_metadata_and_prefix_map(MATCHER_META_YML)
converter, metadata = get_metadata_and_prefix_map(MATCHER_META_YML)