Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new helper utils.get_ordinal_clusters to cluster ordinal numbers based on an offset. #3

Merged
merged 5 commits into from
May 15, 2024

Conversation

duchenean
Copy link
Contributor

No description provided.

@duchenean duchenean force-pushed the MOD-990 branch 4 times, most recently from 885309b to 2faa441 Compare April 25, 2024 12:56
@duchenean duchenean requested review from sgeulette and gbastien April 25, 2024 12:57
@coveralls
Copy link

coveralls commented Apr 25, 2024

Pull Request Test Coverage Report for Build 9091676081

Details

  • 33 of 34 (97.06%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 62.916%

Changes Missing Coverage Covered Lines Changed/Added Lines %
imio/pyutils/utils.py 24 25 96.0%
Totals Coverage Status
Change from base Build 8601731421: 1.9%
Covered Lines: 397
Relevant Lines: 631

💛 - Coveralls

@duchenean
Copy link
Contributor Author

Salut @sgeulette et @gbastien,

L'un de vous peut jeter un oeil ? (je ne sais pas qui est le mainteneur principal)
C'est un simple utilitaire qu'on utilisera dans iA.Délib pour afficher des clusters de points.

Merci!

Copy link
Member

@gbastien gbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @duchenean

j'ai mergé le master + PEP8

Mon PEP8 me dit aussi d'éviter les fonctions "lambda", donc faire un "def display_fn(n): ..." à la place me semble plus lisible? Ressortira + dans la fonction car j'ai du chercher le display_fn (regardé si importé, ...), donc PEP8 n'a pas tort :-)

Tu peux merger après çà, merci!

Gauthier

@duchenean duchenean merged commit 29a7c24 into master May 15, 2024
4 checks passed
@duchenean duchenean deleted the MOD-990 branch May 15, 2024 09:57
@duchenean duchenean restored the MOD-990 branch May 15, 2024 12:02
@duchenean duchenean deleted the MOD-990 branch May 15, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants