Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portal info: better symbol for close button #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnd0e
Copy link
Contributor

@johnd0e johnd0e commented Jan 3, 2019

╽
✕
✖
❌
❎ (proposed in the PR)

Sources:
https://en.wikipedia.org/wiki/X_mark
http://xahlee.info/comp/unicode_crosses.html

@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 3, 2019

todo: change mobile style (no need for borders).

BTW, may be better to place symbol in css.

@modos189
Copy link
Contributor

modos189 commented Jan 3, 2019

If remove the border, it will be better, but...
❎ in github - red symbol on white background, with border
in mobile - white symbol on red background
in browser - white symbol on green background.

I propose to use the material icon "close"

johnd0e referenced this pull request Jan 3, 2019
Added Material icon. In the future, I want to continue to use them
@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 3, 2019

Icon 'close' is like ╳✕✖, so I am not sure that we should prefer it over simple symbol. Or there are some special reasons?

(Personally I like boxed cross, but cannot find similar icon in material)

@modos189
Copy link
Contributor

modos189 commented Jan 5, 2019

There is no box cross, but it is easily implemented using CSS.
The advantage of using only Material icons is that the method of adding icons is then standardized. The same code is used for all icons.

@johnd0e johnd0e added the WIP Work in progress || Proof of the concept label Feb 14, 2019
@johnd0e johnd0e added the core label Mar 20, 2019
@modos189 modos189 force-pushed the master branch 3 times, most recently from a34b800 to 7b9edd5 Compare December 12, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core WIP Work in progress || Proof of the concept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants