-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show linked portals improve #40
Conversation
johnd0e
commented
Dec 28, 2018
•
edited
Loading
edited
- portal images fill full width
- on taphold: text instead of portal pic
- last viewed portal is highlighted
- on mobile:
- single tap to show tooltip
- double tap to go to portal
- on taphold: improved 'show link on map' function
- picture in tooltip
- tooltip now updates on new data coming
- style tweaks
- minor bug fixed
There is minor cosmetic issue left: on click/hover over This code works:
But I feel that it is terribly wrong... |
1 more issue left to fix. |
Added Material icon. In the future, I want to continue to use them
Is it possible to merge the PR but still leave it opened? |
No. We can still leave opened |
9ab75a8
to
72e45ae
Compare
@modos189, please check last commit ( |
72e45ae
to
65ffc85
Compare
Good, but just need to add a property To show icons of link direction |
8a24b1d
to
b0ce935
Compare
@modos189, fixed. |
Then I suggest to add And all prefixes like |
b0ce935
to
7fb54a0
Compare
Well, after some experiments I tend to think that these symbols are hard to see and use as they are ambiguous. Please check if you like transparent containers (in latest commit). P.S.
|
It would be handy as a setting, but by default it would be misleading
like |
Why misleading? |
I thought you were suggesting not displaying incoming links at all. But since it is only about the icon, I agree not to display it for incoming. |
7639fbc
to
4c739fd
Compare
Actually I'm not sure that symbol is good. |
a34b800
to
7b9edd5
Compare
246e8bd
to
6f9964b
Compare
Also: picture in tooltip
6f9964b
to
e2a8735
Compare
in order to be able to see tooltip on single tap
f83f0d7
to
cbd7b52
Compare
dbf0cb8
to
fd0920a
Compare
fd0920a
to
2d05b52
Compare