Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show linked portals improve #40

Merged
merged 25 commits into from
Dec 17, 2021

Conversation

johnd0e
Copy link
Contributor

@johnd0e johnd0e commented Dec 28, 2018

  • portal images fill full width
  • on taphold: text instead of portal pic
  • last viewed portal is highlighted
  • on mobile:
    • single tap to show tooltip
    • double tap to go to portal
  • on taphold: improved 'show link on map' function
  • picture in tooltip
  • tooltip now updates on new data coming
  • style tweaks
  • minor bug fixed

@johnd0e
Copy link
Contributor Author

johnd0e commented Dec 28, 2018

There is minor cosmetic issue left: on click/hover over outOfRage div - it gets re-rendered with updated data, but we still see old tooltip, which has Go to portal instead of real portal title.
Now investigating if it's easy to reopen tooltip with updated content..

This code works:

$('.ui-tooltip-content').html(div.attr('title')); // update tooltip with new content

But I feel that it is terribly wrong...

@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 3, 2019

1 more issue left to fix.
After 59cc312 some styles had changed, so upper portals' boxes are out of bounds of the main portal's picture.

johnd0e referenced this pull request Jan 3, 2019
Added Material icon. In the future, I want to continue to use them
@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 3, 2019

Is it possible to merge the PR but still leave it opened?

@modos189
Copy link
Contributor

modos189 commented Jan 3, 2019

No. We can still leave opened

@johnd0e johnd0e force-pushed the show-linked-portals-improve branch 4 times, most recently from 9ab75a8 to 72e45ae Compare January 7, 2019 22:07
@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 7, 2019

@modos189, please check last commit (portal images fill full width)
Are images look better now?
Or I should revert it?

@johnd0e johnd0e force-pushed the show-linked-portals-improve branch from 72e45ae to 65ffc85 Compare January 8, 2019 08:08
@modos189
Copy link
Contributor

modos189 commented Jan 8, 2019

Good, but just need to add a property
z-index: 1;
in
.showLinkedPortalLink.incoming::before, .showLinkedPortalLink.outgoing::before

To show icons of link direction

@johnd0e johnd0e force-pushed the show-linked-portals-improve branch 2 times, most recently from 8a24b1d to b0ce935 Compare January 8, 2019 09:48
@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 8, 2019

@modos189, fixed.
And what do you think about border-radius and box-shadow?

@modos189
Copy link
Contributor

modos189 commented Jan 8, 2019

Then I suggest to add
background: #00000080;
to be seen against the background of bright photos.

And all prefixes like -webkit-border-radius must be specified before the announcement border-radius

@johnd0e johnd0e force-pushed the show-linked-portals-improve branch from b0ce935 to 7fb54a0 Compare January 8, 2019 10:17
@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 8, 2019

Then I suggest to add background: #00000080;

Well, after some experiments I tend to think that these symbols are hard to see and use as they are ambiguous.
I have another proposition: after all, we care only outgoing links (as they are limited). So wouldn't it better to mark outgoing only?

Please check if you like transparent containers (in latest commit).

P.S.
After that I want to test other concepts:

  • Portal info (text) instead of images
  • Portal info over the images (which have to be semi-transparent in order to keep text readable)

@modos189
Copy link
Contributor

modos189 commented Jan 8, 2019

I have another proposition: after all, we care only outgoing links (as they are limited). So wouldn't it better to mark outgoing only?

It would be handy as a setting, but by default it would be misleading

if you like transparent containers

like

@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 8, 2019

It would be handy as a setting, but by default it would be misleading

Why misleading?
Several days ago we have no symbols at all, tomorrow we'll get some symbol over outgoing.
It couldn't be misleading, as there are also clear text labels incoming/outgoing.

@modos189
Copy link
Contributor

modos189 commented Jan 8, 2019

I thought you were suggesting not displaying incoming links at all. But since it is only about the icon, I agree not to display it for incoming.

@johnd0e johnd0e force-pushed the show-linked-portals-improve branch from 7639fbc to 4c739fd Compare January 8, 2019 12:16
@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 8, 2019

show-linked-portals: more bold symbol

Actually I'm not sure that symbol is good.
And we also need to play with it's position (in order to not interfere with text).

@johnd0e johnd0e added the WIP Work in progress || Proof of the concept label Feb 11, 2019
@johnd0e johnd0e added the plugin label Mar 20, 2019
@modos189 modos189 force-pushed the master branch 3 times, most recently from a34b800 to 7b9edd5 Compare December 12, 2020 07:21
@johnd0e johnd0e force-pushed the show-linked-portals-improve branch from 246e8bd to 6f9964b Compare December 13, 2021 19:53
@johnd0e johnd0e force-pushed the show-linked-portals-improve branch from 6f9964b to e2a8735 Compare December 14, 2021 08:54
@johnd0e johnd0e force-pushed the show-linked-portals-improve branch 2 times, most recently from f83f0d7 to cbd7b52 Compare December 14, 2021 11:55
@johnd0e johnd0e removed the WIP Work in progress || Proof of the concept label Dec 14, 2021
@johnd0e johnd0e force-pushed the show-linked-portals-improve branch from dbf0cb8 to fd0920a Compare December 14, 2021 19:48
@johnd0e johnd0e force-pushed the show-linked-portals-improve branch from fd0920a to 2d05b52 Compare December 15, 2021 11:40
@johnd0e johnd0e merged commit 807cb57 into IITC-CE:master Dec 17, 2021
@johnd0e johnd0e deleted the show-linked-portals-improve branch December 17, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants