Multi project extension #221

MysticJay · 2019-07-10T16:43:32Z

This is the first and IMHO most important plugin ZasoGD has created.
The script itself is unchanged compared to the original file.
Headers and footers are changed (not sure about the @match line)

Zaso's startup wrapper has been commented out, although I do not yet understand why.

The script has been tested in IITC-CE - Menu item load.

no changes to Zaso's script.

Header, Tail wrapper () removed

Code Snippet for integrating other plugins with MPE

@match

removed commented functions and @match

MysticJay · 2019-07-10T20:51:29Z

IMHO ready to merge

modos189 · 2019-07-10T21:02:20Z

Contents of Multi-Projects-Extension.doc file please place as comment in multi-projects-extension.user.js file, and delete Multi-Projects-Extension.doc

MysticJay · 2019-07-10T21:08:33Z

Does IITC-CE work with Block-Comments? /* and */?

Sample Code moved to main script DOC removed

modos189 · 2019-07-10T21:19:05Z

You can use multiline comments. Yeah, like you just did.

We have documentation (in the doc folder) but I don't like it very much, it should be generated based on comments in the code.

modos189 · 2019-07-10T21:21:58Z

Pay attention to my two remaining comments https://github.com/IITC-CE/ingress-intel-total-conversion/pull/221/files

Header fixed, Indentation reduced

plugins/multi-projects-extension.user.js

modos189 · 2019-07-10T21:40:13Z

Thanks, this PR will be merged into a new release

johnd0e · 2019-07-11T13:09:49Z

Thanks, this PR will be merged into a new release

I'd rather think about include support of this in IITC core.
May be in some other form (need to investigate functionality deeper).

Added MPE-Support for Drawtools.

MysticJay · 2019-07-29T19:49:47Z

To test the functionality:

import Multi-Project-Extension.user.js to externals
import DRAW2-beta.user.js to externals
disable regular DRAW-Tools
enable MPE and Draw2-beta
Create a drawing
from MultiProjects Menu click on the "+" and create a new project.
Existing drawing should be cleared.
create a new draw.
Use the dialogue to switch between drawings
Use the settings dialogue to add the selection menu to the MainMenu.

Added MPE-Support to current Bookmarks. import to extrenals and disable standard BMRKS-plugin to test

MysticJay · 2019-07-29T20:26:34Z

To test:
disable standard Bookmarks-Plugin,
import bkmks2.beta to externals

johnd0e · 2019-07-30T11:51:01Z

I do not get why you need separate plugin (draw2). You may just extend single draw-tools (in runtime)
But if you still need draw2 then please make your changes reviewable:
- copy draw-tools.user.js to draw-tools2.user.js
- make your changes in separate commit(s)

MysticJay · 2019-07-30T12:30:38Z

Bare with me, I am new to GIT, so it seemed to be safer to create a separate draw than to fiddle around in the original draw. At least this way does not break the existing tools and existing extensions to it. When I started porting Zaso's changes it was not clear to me how deep the changes would be.

The changes can easily be followed by just renaming DRAW2-beta.user.js to draw-tools.user.js
Also the contributions should show the changes step by step, as the first contribution of the file was the original draw-tools (just a copy)

Draw2 and Bkmarks2 is "only" a Draft to show how MPE is working. Due to the same namespace both use with the old Versions, the data is completely compatible. If you find a problem with MPE it is easy to switch back to the old plugins without loosing anything.

Also there are many other proposals that need to be reviewed and I think it is easier to add these to a forked plugin and finally just replace the old plugin than to daily send in new contributions.

As you wrote earlier we should rather think of adding MPE to the code as "Projects" or "Project-Manager".

johnd0e · 2019-07-30T12:45:26Z

Also the contributions should show the changes step by step, as the first contribution of the file was the original draw-tools (just a copy)

Yeah, but for draw-tools I see only single commit 9d89089

Better if there were (1) initial (2) changes for MPE

Also there are many other proposals that need to be reviewed and I think it is easier to add these to a forked plugin

We can play with forked plugins, but I do not think that we should release them as they are. It'd be confusing.

As you wrote earlier we should rather think of adding MPE to the code as "Projects" or "Project-Manager".

Yes. It is general principle.
But there may be different implementations of Multi-Projects idea.
I need time to check it.

Multi-Project support for Bookmarks and Draw-Tools added. (imported changes from beta)

MysticJay · 2019-07-30T15:13:24Z

Changes applied on original files. removed development (beta) files.

johnd0e · 2019-07-30T15:19:54Z

Ok. I will review proposed changes ASAP (but do not expect it to be fast, definitely not earlier than 0.30 release).

johnd0e · 2019-07-31T08:02:26Z

Some general thoughts:

MPE allows to group Draws/Bookmarks by related project.
What if we need some particular set of Draws or Bookmarks in several projects?
Oops. We can't.

I suppose we could improve project idea.
E.g.:
Bookmarks already has folders. So we might just select existent folders to add them into project.

johnd0e · 2019-08-07T08:16:49Z

plugins/font-awesome.user.js

@@ -0,0 +1,30 @@
+// ==UserScript==
+// @id             iitc-plugin-font-awesome@Zaso
+// @name           IITC plugin: Font Awesome


If we include web font - we should include it in core, to make it available out-of-the-box.
(and it is still unclear if should include - #236)

johnd0e · 2019-08-07T08:17:02Z

plugins/font-awesome.user.js

+	$('<link>')
+		.prop('type', 'text/css')
+		.prop('rel', 'stylesheet')
+		.prop('href', 'https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css')


Why use 4.7 instead of current (5.10.1)?
https://fontawesome.com/

No objection to use 5.10.1.
Just not tested it.

MysticJay · 2019-08-08T21:38:15Z

MPE is about replacing the complete namespace of a plugin. Sharing parts between different namespaces would require them to be in an additional namespace.
Whatever I do not think this is needed Copy paste between different projects is possible and helps to avoid accidental sharing of confidential Information between projects.
I highly recommend to not share anything between projects.

johnd0e · 2019-08-08T21:41:52Z

I still don't get what do you mean. Explain please.

MysticJay · 2019-08-08T21:46:59Z

You asked about sharing parts of draw or bookmarks between projects.

MysticJay · 2019-08-31T12:44:34Z

What about moving this to the core?

johnd0e · 2019-08-31T13:39:22Z

It is planned

There are some unresolved issues

Version alinged with ZasoItems-CE

MysticJay added 2 commits July 10, 2019 15:57

initial import

7b9787b

no changes to Zaso's script.

Obvious changes done

5cdcb80

Header, Tail wrapper () removed

MysticJay changed the title ~~Muti project extension~~ Multi project extension Jul 10, 2019

MysticJay added 2 commits July 10, 2019 22:23

Create Multi-Projects-Extension.doc

f106b51

Code Snippet for integrating other plugins with MPE

Update multi-projects-extension.user.js

83a0d78

removed commented functions and @match

modos189 self-requested a review July 10, 2019 21:07

modos189 added enhancement New feature or request plugin labels Jul 10, 2019

Code Snippet moved

99ac1ad

Sample Code moved to main script DOC removed

Update multi-projects-extension.user.js

06c17e2

Header fixed, Indentation reduced

modos189 previously approved these changes Jul 10, 2019

View reviewed changes

modos189 added this to the v0.30 milestone Jul 10, 2019

Create font-awesome.user.js

58d24cf

modos189 mentioned this pull request Jul 10, 2019

Add Zaso plugins #219

Open

3 tasks

Create draw2-beta.user.js

9d89089

Added MPE-Support for Drawtools.

Create bkmkrs2-beta.user.js

8c7fad1

Added MPE-Support to current Bookmarks. import to extrenals and disable standard BMRKS-plugin to test

Multi-Project-Support

1e24bba

Multi-Project support for Bookmarks and Draw-Tools added. (imported changes from beta)

johnd0e mentioned this pull request Aug 7, 2019

Include icons font? #236

Open

johnd0e reviewed Aug 7, 2019

View reviewed changes

johnd0e removed this from the v0.30 milestone Oct 10, 2019

Update multi-projects-extension.user.js

2199f2d

Version alinged with ZasoItems-CE

MysticJay closed this Jan 15, 2020

MysticJay deleted the Muti-Project-Extension branch January 15, 2020 21:12

johnd0e mentioned this pull request Dec 24, 2020

Multi project extension: fixes #414

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi project extension #221

Multi project extension #221

MysticJay commented Jul 10, 2019 •

edited

Loading

MysticJay commented Jul 10, 2019

modos189 commented Jul 10, 2019

MysticJay commented Jul 10, 2019 •

edited

Loading

modos189 commented Jul 10, 2019

modos189 commented Jul 10, 2019

modos189 commented Jul 10, 2019

johnd0e commented Jul 11, 2019

MysticJay commented Jul 29, 2019

MysticJay commented Jul 29, 2019

johnd0e commented Jul 30, 2019

MysticJay commented Jul 30, 2019

johnd0e commented Jul 30, 2019

MysticJay commented Jul 30, 2019

johnd0e commented Jul 30, 2019 •

edited

Loading

johnd0e commented Jul 31, 2019

johnd0e Aug 7, 2019 •

edited

Loading

johnd0e Aug 7, 2019 •

edited

Loading

MysticJay Aug 8, 2019

MysticJay commented Aug 8, 2019

johnd0e commented Aug 8, 2019

MysticJay commented Aug 8, 2019

MysticJay commented Aug 31, 2019

johnd0e commented Aug 31, 2019

Multi project extension #221

Multi project extension #221

Conversation

MysticJay commented Jul 10, 2019 • edited Loading

MysticJay commented Jul 10, 2019

modos189 commented Jul 10, 2019

MysticJay commented Jul 10, 2019 • edited Loading

modos189 commented Jul 10, 2019

modos189 commented Jul 10, 2019

modos189 commented Jul 10, 2019

johnd0e commented Jul 11, 2019

MysticJay commented Jul 29, 2019

MysticJay commented Jul 29, 2019

johnd0e commented Jul 30, 2019

MysticJay commented Jul 30, 2019

johnd0e commented Jul 30, 2019

MysticJay commented Jul 30, 2019

johnd0e commented Jul 30, 2019 • edited Loading

johnd0e commented Jul 31, 2019

johnd0e Aug 7, 2019 • edited Loading

Choose a reason for hiding this comment

johnd0e Aug 7, 2019 • edited Loading

Choose a reason for hiding this comment

MysticJay Aug 8, 2019

Choose a reason for hiding this comment

MysticJay commented Aug 8, 2019

johnd0e commented Aug 8, 2019

MysticJay commented Aug 8, 2019

MysticJay commented Aug 31, 2019

johnd0e commented Aug 31, 2019

MysticJay commented Jul 10, 2019 •

edited

Loading

MysticJay commented Jul 10, 2019 •

edited

Loading

johnd0e commented Jul 30, 2019 •

edited

Loading

johnd0e Aug 7, 2019 •

edited

Loading

johnd0e Aug 7, 2019 •

edited

Loading