Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earth radius #122

Closed
johnd0e opened this issue Feb 27, 2019 · 3 comments · Fixed by #340
Closed

Earth radius #122

johnd0e opened this issue Feb 27, 2019 · 3 comments · Fixed by #340
Labels
development general development issue

Comments

@johnd0e
Copy link
Contributor

johnd0e commented Feb 27, 2019

commit 522ef34f77c86c54cc7586a298d5a6f74f75aef4
Author: Jon Atkins <[email protected]>
Date:   Thu Mar 12 20:47:05 2015 +0000

    earth radius: change leaflet and leaflet-draw to use the radius value used by the s2 geometry library

diff --git a/external/L.Geodesic.js b/external/L.Geodesic.js
diff --git a/external/leaflet-src.js b/external/leaflet-src.js
diff --git a/external/leaflet.draw.js b/external/leaflet.draw.js

We need to investigate if this change was necessary.

Originally posted by @johnd0e in #78 (comment)

@johnd0e johnd0e added the development general development issue label Feb 27, 2019
@johnd0e
Copy link
Contributor Author

johnd0e commented Feb 27, 2019

@johnd0e johnd0e mentioned this issue Mar 28, 2019
6 tasks
@johnd0e
Copy link
Contributor Author

johnd0e commented Aug 10, 2019

diff --git a/external/L.Geodesic.js b/external/L.Geodesic.js

Radius value here does not have to be precise, so that change had no sense.

@McBen
Copy link
Contributor

McBen commented Feb 16, 2020

S2-Earth-Radius is used in distance calculation.
You'll see the difference in draw-tools (or other plugins when they use LatLng.distanceTo)

Current used radius result im more accurate distances but Ingress uses the S2 value for link-distance calculation - which is sometimes a important value.

johnd0e pushed a commit that referenced this issue May 2, 2020
boot.js: change earth radius constant for more precise distance calculations

Closes #122, closes #332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development general development issue
Projects
None yet
2 participants