Skip to content

Conversation

@jamesmisson
Copy link
Collaborator

Some changes necessary for UV issue 1503 UniversalViewer/universalviewer#1503

@jamesmisson jamesmisson marked this pull request as draft July 29, 2025 17:00
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 29, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@jamesmisson jamesmisson marked this pull request as ready for review July 29, 2025 17:11
@jamesmisson jamesmisson requested a review from demiankatz July 30, 2025 08:36
Copy link
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Obviously the problems discussed elsewhere regarding multi-valued behaviors and viewing hints apply here as well, but that's a bigger problem, and following existing convention should be good enough to get us off the ground for now.

In the long run, I wonder if we need to add getBehaviors and getViewingHints methods, and then start replacing the legacy singular versions with the new plural ones (complete with "array contains" checks instead of straight string comparisons).

It might also be a good idea to add more tests here -- it does appear that some testing infrastructure exists -- but maybe that's a separate project too; I'll leave it to your discretion.

In any case, I'm approving this now, and you can merge whenever you feel ready.

@jamesmisson jamesmisson merged commit 717b666 into IIIF-Commons:main Aug 1, 2025
2 checks passed
@jamesmisson jamesmisson deleted the uv-issue-1503-behavior-continuous branch August 1, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants