Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add acr container registry #48

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

Lusengeri
Copy link
Contributor

PR Title: Add Azure Container Registry (ACR) with AKS Integration

Summary

This PR introduces an Azure Container Registry (ACR) with a Standard SKU and integrates it with the existing AKS cluster for seamless image pulls. Additionally, a service principal access token is created for GitHub Actions workflows with push permissions enabled.

Addresses #60 & #80

Changes

  • Created an Azure Container Registry (ACR) with a Standard SKU.
  • Configured AKS pull permissions by assigning the azurerm_kubernetes_cluster.ifrcgo.kubelet_identity[0].object_id attribute to the ACR role-based access control (RBAC), allowing the AKS kubelet identity to pull images without explicit secrets.
  • Generated an ACR access token with push permissions for use in GitHub Actions workflows.

Why this is needed

  • Enhances security by allowing AKS to pull images without storing credentials.
  • Simplifies authentication for GitHub Actions, enabling automated container image pushes to ACR.
  • Ensures best practices by leveraging Azure-native identity-based access management.

Next Steps

  • Update GitHub Actions workflows to use the ACR token for image pushes.
  • Validate AKS workloads successfully pull images from the registry.

@Lusengeri Lusengeri requested review from sunu and thenav56 February 3, 2025 04:46
@szabozoltan69 szabozoltan69 merged commit 23feab2 into develop Feb 4, 2025
@szabozoltan69 szabozoltan69 deleted the feature/add-acr-container-registry branch February 4, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants