Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Regenerate field report number if event and country changes #2400

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

susilnem
Copy link
Member

@susilnem susilnem commented Feb 5, 2025

Addresses

  • Setting the value of fr_num to None if event is changed
  • Passing field report number id while updating the field report

Changes

  • updating the fr number if event is changed
  • Setting fr_num to None if countries and event changed from serializer and While calling signal.

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

@susilnem susilnem changed the title Fix: Set field report number to none if event is changed Fix: Regenerate field report number if event and country changes Feb 6, 2025
@samshara samshara requested a review from thenav56 February 12, 2025 08:01
@thenav56
Copy link
Member

@szabozoltan69 When you have time, please review and merge this PR.

@szabozoltan69 szabozoltan69 merged commit 3c43121 into develop Feb 12, 2025
3 checks passed
@szabozoltan69 szabozoltan69 deleted the hotfix/fr_num_issue branch February 12, 2025 08:50
@szabozoltan69
Copy link
Contributor

@thenav56 merged, deployed to Staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants