Email Implementation on local units #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susilnem
requested review from
Rup-Narayan-Rajbanshi and
thenav56
and removed request for
Rup-Narayan-Rajbanshi
tnagorra
requested changes
Dec 27, 2024
|
|
||
| {% endif %} | ||
|
|
||
| {% if global_admin %} |
There was a problem hiding this comment.
Not sure if the variable name is correct here.
There was a problem hiding this comment.
They are passed through context variable from this file local_units/management/commands/notify_validators.py
thenav56
requested changes
Dec 27, 2024
|
|
||
| {% endif %} | ||
|
|
||
| {% if global_admin %} |
There was a problem hiding this comment.
They are passed through context variable from this file local_units/management/commands/notify_validators.py
thenav56
requested changes
Dec 30, 2024
thenav56
requested changes
Dec 31, 2024
thenav56
approved these changes
Dec 31, 2024
susilnem
added a commit
that referenced
this pull request
Jan 7, 2025
* Email setup for editing local unit * Add email template for create and update local unit * Add email backend * Ad changes for the email template * Email for deprecate and changes on template * Changes in template and commenting out tls service * Add changes for email and create command for notifying regional and global validators * Add tags for regional and global validator * Add notify validators to values file * fix issue on deprecate api * Add api for template preview * Add USE_EMAIL_SMPT flag and last_sent_validator_type in model, Refactor email sending logic * add a comment in email_context * Add minor changes on email smtp * Add email preview api for local units * Add new views for email preview and changes on utils and email task * Changes in email preview api * Update localunit mail template * Fix issue on email preview --------- Co-authored-by: Shreeyash Shrestha <[email protected]>
susilnem
added a commit
that referenced
this pull request
Jan 13, 2025
* Email setup for editing local unit * Add email template for create and update local unit * Add email backend * Ad changes for the email template * Email for deprecate and changes on template * Changes in template and commenting out tls service * Add changes for email and create command for notifying regional and global validators * Add tags for regional and global validator * Add notify validators to values file * fix issue on deprecate api * Add api for template preview * Add USE_EMAIL_SMPT flag and last_sent_validator_type in model, Refactor email sending logic * add a comment in email_context * Add minor changes on email smtp * Add email preview api for local units * Add new views for email preview and changes on utils and email task * Changes in email preview api * Update localunit mail template * Fix issue on email preview --------- Co-authored-by: Shreeyash Shrestha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Changes
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.