Add API to deprecate local unit #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samshara
changed the title
thenav56
requested changes
Dec 11, 2024
susilnem
requested changes
Dec 11, 2024
susilnem
added a commit
that referenced
this pull request
Dec 16, 2024
* WIP : Add api for deprecation of local unit. * Add api and test case for deprecate api for local unit. * Revert the depricated local-unit. * Add api and test case for deprecate api for local unit. * Fix test for local unit. * Clean up after rebase. * Remove duplicate deprecate function. * Fix typo for deprecate. * Pr fixes. * Add validation for already existing local unit object. * Modify test case for local unit. * Add validation test for deprecate local unit. * PR fixes. * Fix failed test case for local unit. * Add validation for deprecated_reason field in local unit. * Change in deprecate api and serializer --------- Co-authored-by: Sushil Tiwari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Changes
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.