Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldReport and Emergencies Translation #2264

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

susilnem
Copy link
Member

@susilnem susilnem commented Sep 17, 2024

Addresses

Changes

  • Add new field title in FieldReport and Event/Emergencies
  • New migration file

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

@susilnem susilnem marked this pull request as draft September 17, 2024 09:04
@susilnem susilnem force-pushed the feature/field-report-translation branch 2 times, most recently from 1573b78 to 235766e Compare September 17, 2024 09:46
@susilnem susilnem force-pushed the feature/field-report-translation branch 7 times, most recently from 23ca907 to f7ce814 Compare October 8, 2024 04:23
@szabozoltan69
Copy link
Contributor

Why do we introduce the "title" field to these models?

@susilnem susilnem force-pushed the feature/field-report-translation branch from f7ce814 to 1473750 Compare October 8, 2024 08:10
@susilnem
Copy link
Member Author

susilnem commented Oct 8, 2024

@szabozoltan69 Currently, FR titles are auto-generated on the frontend, which are translated later and cannot change once it is created. We need to separate out the title from summary for translation and generate respective formatted summary.

@szabozoltan69 szabozoltan69 force-pushed the develop branch 2 times, most recently from 14cb672 to 682a280 Compare October 8, 2024 12:54
@susilnem susilnem force-pushed the feature/field-report-translation branch from 1473750 to 157b856 Compare October 9, 2024 07:53
@susilnem susilnem force-pushed the feature/field-report-translation branch 2 times, most recently from 202d599 to f264ce2 Compare October 17, 2024 18:17
@susilnem susilnem requested a review from thenav56 October 22, 2024 09:01
@susilnem susilnem force-pushed the feature/field-report-translation branch from f264ce2 to 074e335 Compare November 5, 2024 10:24
@susilnem susilnem force-pushed the feature/field-report-translation branch 3 times, most recently from d590fa6 to 514e4a3 Compare November 13, 2024 05:16
@susilnem susilnem force-pushed the feature/field-report-translation branch 3 times, most recently from c39cc00 to 2dc83a4 Compare November 22, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants