Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove additionalDomain that's no longer being used #2095

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove additionalDomain that's no longer being used #2095

wants to merge 1 commit into from

Conversation

sunu
Copy link
Collaborator

@sunu sunu commented Apr 10, 2024

Removes the additionalDomain setting and k8s resources associated with it. Also removes hardcoded references to api.go.ifrc.org

cc @batpad @szabozoltan69

@sunu sunu marked this pull request as ready for review April 10, 2024 09:35
szabozoltan69
szabozoltan69 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@szabozoltan69 szabozoltan69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that work!

@szabozoltan69 szabozoltan69 force-pushed the develop branch 4 times, most recently from 17d0645 to a8b22d7 Compare July 22, 2024 16:28
@szabozoltan69 szabozoltan69 force-pushed the develop branch 2 times, most recently from 14cb672 to 682a280 Compare October 8, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabozoltan69 szabozoltan69 szabozoltan69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunu @szabozoltan69