Skip to content

Fix p-values workaround computation #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 22, 2023
Merged

Fix p-values workaround computation #249

merged 4 commits into from
Jul 22, 2023

Conversation

jaime-cespedes-sisniega
Copy link
Contributor

@jaime-cespedes-sisniega jaime-cespedes-sisniega commented Jul 22, 2023 •
edited
Loading

  • Replace z-score (workaround) when computing p-values with the ratio of times a permuted statistic is equal or greater than the observed statistic in PermutationTestDistanceBased callback.
  • Remove z-score function. Used only by the deprecated way of computing p-values.
  • Update MNIST multivatiate example to updated to the new p-values calculation.

📚 Documentation preview 📚: https://frouros--249.org.readthedocs.build/en/249/

@jaime-cespedes-sisniega jaime-cespedes-sisniega added the bug Something isn't working label Jul 22, 2023
@jaime-cespedes-sisniega jaime-cespedes-sisniega merged commit 8368845 into main Jul 22, 2023
@jaime-cespedes-sisniega jaime-cespedes-sisniega deleted the fix-permutation-test-p-values branch July 22, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jaime-cespedes-sisniega jaime-cespedes-sisniega

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jaime-cespedes-sisniega