Added check for URI when verifying if emulator connection string #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using AddCosmosRepositoryClient, options and clientOptions successfully process when using a connection string. But when a named connection string that represents the "AccountEndpoint", options' action successfully processes it as an AccountEndpoint that will use DefaultCredential but IsEmulatorConnectionString throws an exception when creating the DbConnectionStringBuilder
Contributor
Author
|
Small issue I noticed when playing around test containers. Works just great when using a locally running emulator, but when I specify a cloud cosmos, via just the URI, it would throw exceptions. I found that the culprit it the string extensions method. |
Contributor
Author
|
Let me know if ya'll need anything from me @IEvangelist @mumby0168 |
IEvangelist
approved these changes
Jun 30, 2025
This was referenced Jul 23, 2025
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using AddCosmosRepositoryClient, options and clientOptions successfully process when using a connection string. But when a named connection string that represents the "AccountEndpoint", options' action successfully processes it as an AccountEndpoint that will use DefaultCredential but IsEmulatorConnectionString throws an exception when creating the DbConnectionStringBuilder