Migrate to V2 API #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework to call the new V2 API and to correct issue where shows indexed with TMDB did not work.
This reverts commit 68f1c09.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spotted an issue where I was missing posters for some of my shows. Digging further it was all the ones indexed by TMDB instead of TVDB. The V1 API doesn't support this so gives the wrong ID back which means then the images are not fetched.
So to fix, I reworked the requests to use V2 api calls. Have had this running now for a week without issue so created a pull in case you want to merge in /cherry pick bits!