New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shape check and default to True if an exception is raised in is_different #933

Merged

thequilo merged 1 commit into IDSIA:master from n-gao:is_different_fix

Oct 17, 2024

Contributor

n-gao commented Oct 17, 2024

replaces #932


          add shape check and default to True if an exception is raised

589e847

n-gao mentioned this pull request

restore old is_different #932

Closed

thequilo approved these changes

View reviewed changes

Collaborator

thequilo commented Oct 17, 2024 •

edited

Loading

The failing tests are unrelated to this change and should be fixed in another PR. They are related to mongo and mongomock.

This is the issue: mongomock/mongomock#903

thequilo merged commit d728e32 into IDSIA:master

18 of 26 checks passed

thequilo mentioned this pull request

Pin mongomock #934

Merged

n-gao mentioned this pull request

is_different behavior differs with numpy vs without numpy #930

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet