Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated importlib.resources to stop using deprecated path function #1550

Merged
merged 12 commits into from
Feb 14, 2025

Conversation

azaidi06
Copy link
Contributor

Fixes

This resolves issue #1542

Summary/Motivation:

importlib.resources.path is deprecated and importlib.resources.files is the remedy for all python version applicable in IDAES (3.9+)

Changes proposed in this PR:

updated importlib.resrouces functionality to now use "files" function instead of "path"

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Dec 19, 2024
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to go pending these minor fixes

idaes/apps/grid_integration/tests/test_integration.py Outdated Show resolved Hide resolved
idaes/apps/grid_integration/tests/test_integration.py Outdated Show resolved Hide resolved
idaes/tests/prescient/test_prescient.py Outdated Show resolved Hide resolved
idaes/tests/prescient/test_prescient.py Outdated Show resolved Hide resolved
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review January 30, 2025 19:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (997c3a5) to head (0e36cfe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1550      +/-   ##
==========================================
- Coverage   76.85%   76.85%   -0.01%     
==========================================
  Files         394      394              
  Lines       63233    63233              
  Branches    10355    10355              
==========================================
- Hits        48598    48595       -3     
- Misses      12190    12194       +4     
+ Partials     2445     2444       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl lbianchi-lbl self-requested a review February 14, 2025 16:14
@lbianchi-lbl lbianchi-lbl added the CI:run-integration triggers_workflow: Integration label Feb 14, 2025
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Feb 14, 2025
@lbianchi-lbl lbianchi-lbl merged commit b24fde4 into IDAES:main Feb 14, 2025
38 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants