-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated importlib.resources to stop using deprecated path function #1550
Conversation
… instead of *path*
… to lines being too long with the new as_file(files(... paradigm needed
…ccessing functions from that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to go pending these minor fixes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
==========================================
- Coverage 76.85% 76.85% -0.01%
==========================================
Files 394 394
Lines 63233 63233
Branches 10355 10355
==========================================
- Hits 48598 48595 -3
- Misses 12190 12194 +4
+ Partials 2445 2444 -1 ☔ View full report in Codecov by Sentry. |
Fixes
This resolves issue #1542
Summary/Motivation:
importlib.resources.path
is deprecated and importlib.resources.files is the remedy for all python version applicable in IDAES (3.9+)Changes proposed in this PR:
updated importlib.resrouces functionality to now use "files" function instead of "path"
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: