-
Notifications
You must be signed in to change notification settings - Fork 5
fix(browser): remove --no-sandbox and persist profile across restarts #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bcb8ce3
fix(browser): remove --no-sandbox and persist profile across restarts
yalexx 3f021fa
browser fix
yalexx 2f2e807
feat(remote-control): Cloudflare Quick Tunnel + portal linking
yalexx 7fea1df
test: register remoteControl namespace + adapt ws-config expectations
yalexx 0d8e8df
fix(tunnel): route VNC/chat/dashboard through port 80 with correct or…
yalexx 5a5c8c1
Merge remote-tracking branch 'origin/beta' into remote-control
yalexx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| [Unit] | ||
| Description=ClawBox Cloudflare Quick Tunnel | ||
| After=network-online.target clawbox-setup.service | ||
| Wants=network-online.target | ||
|
|
||
| [Service] | ||
| Type=simple | ||
| User=clawbox | ||
| WorkingDirectory=/home/clawbox/clawbox | ||
| ExecStart=/home/clawbox/clawbox/scripts/run-tunnel.sh | ||
| Restart=on-failure | ||
| RestartSec=5 | ||
| TimeoutStartSec=30 | ||
| TimeoutStopSec=15 | ||
| StandardOutput=journal | ||
| StandardError=journal | ||
| Environment=CLAWBOX_ROOT=/home/clawbox/clawbox | ||
| Environment=LOCAL_SERVICE_URL=http://localhost:80 | ||
|
|
||
| # ── Sandboxing ───────────────────────────────────────────────────────────── | ||
| # Light-touch hardening that works with the bash-wrapped cloudflared process. | ||
| # Heavier restrictions (ProtectSystem=strict, namespacing) conflict with the | ||
| # shell pipeline setup on this Jetson kernel. | ||
| NoNewPrivileges=yes | ||
| PrivateTmp=yes | ||
| ProtectKernelTunables=yes | ||
| ProtectKernelModules=yes | ||
| ProtectControlGroups=yes | ||
| RestrictSUIDSGID=yes | ||
|
|
||
| # ── Resource caps ────────────────────────────────────────────────────────── | ||
| CPUAccounting=yes | ||
| MemoryAccounting=yes | ||
| MemoryMax=256M | ||
| CPUQuota=50% | ||
|
|
||
| [Install] | ||
| WantedBy=multi-user.target | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: ID-Robots/clawbox
Length of output: 840
🏁 Script executed:
Repository: ID-Robots/clawbox
Length of output: 4325
The tunnel service will be incorrectly enabled at boot, contradicting the on-demand requirement.
The service unit has good security properties (sandboxing, resource limits, unprivileged user, proper dependencies), but there is a critical gap in the install logic:
The
systemctl enableloop ininstall.sh(lines 825–829) skips only template services (@*) andclawbox-browser.service. Sinceclawbox-tunnel.servicematches neither condition, it will be enabled at boot despite the stated goal of on-demand-only operation. The comment at line 911–912 reflects the intended behavior, but the enable logic doesn't enforce it.Add
clawbox-tunnel.serviceto the skip conditions:🤖 Prompt for AI Agents