Revert #393 β 34 lines of bash and an awk extractor to append a paragraph - #394
Conversation
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: π Files selected for processing (3)
π€ Files with no reviewable changes (3)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. π WalkthroughWalkthroughThe gateway pre-start script no longer migrates the AI model limits section into existing ChangesCLAWBOX.md migration removal
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: βͺ Minimal Β· up to This change removes the runtime document-editing machinery and its associated tests; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested labels: π₯ Pre-merge checks | β 4 | β 1β Failed checks (1 warning)
β Passed checks (4 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Comment |
π¦ ClawReviewClaws waving β here's what this change is about. Reverts #393 (7c4ab60), which added a 34-line bash block with an awk state-machine extractor and 11 tests to surgically append an AI model limits paragraph to pre-existing customer CLAWBOX.md files. Yanko called the machinery too heavy for the problem it solved, so this PR removes all of it β the shell block, the marked template section, and the full test file β leaving beta clean while a simpler follow-up approach is designed. At a glance
Good to know
β ClawReview π¦. I set the scene; CodeRabbit reviews the code; you decide. Conventions: docs. |
Reverts #393 (
7c4ab60) on Yanko's call. He is right: the machinery outgrew the problem.The problem was one sentence β the box tells customers its context is 128K when it is 1M. What #393 built for that: 34 lines of shell, an
awkstate machine extracting a marked section out of a template at runtime, marker-pair validation, and 11 tests covering dangling openers and orphan closers. All of that exists to append a paragraph to a markdown file without clobbering user edits β a constraint invented by the design, not by the requirement.The 128K statement is still wrong and still worth fixing. It should come back as something smaller. The obvious candidate:
A separate managed file.
CLAWBOX-AI.md, owned by us, overwritten on every gateway start, referenced fromAGENTS.mdthe wayCLAWBOX.mdalready is. No markers, no extractor, no idempotence question, no risk of touching anything a customer wrote β because it is not their file. Three lines ofinstall -m 644.Better still if the limits belong in the agent's own instructions rather than a doc it may or may not read, but that is a bigger question about where device facts live.
The two CodeRabbit findings on #393 were both real and both fixed; neither is a reason to keep the shape. Reverting now rather than iterating on top keeps
betaclean while the simpler version is written.π€ Generated with Claude Code
Summary by CodeRabbit
Documentation
Behavior Changes
CLAWBOX.mdfiles are no longer automatically updated with the AI model limits section during gateway startup.AGENTS.mdreference handling remain unchanged.Tests
CLAWBOX.mdmigration behavior.