chore: stop the weekly novnc bump and report coverage on a red build - #380
Conversation
The manifest pins @novnc/novnc exactly because 1.7.0 removes the subpath imports this codebase uses, but that release is a minor, so the weekly run rewrote the pin and opened a PR that could only fail. Ignore that one bump for that one package. Separately, the coverage summary was not written when a test failed, so the workflow step that runs on failure specifically to report numbers never had a file to read.
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: π Files selected for processing (2)
π WalkthroughWalkthroughThe pull request pins ChangesDependency policy
Coverage reporting
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: π₯ Pre-merge checks | β 4 | β 1β Failed checks (1 warning)
β Passed checks (4 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
π¦ ClawReviewScuttled over to say hello and get you oriented π¦ Two CI housekeeping fixes. The Dependabot config now ignores minor-version bumps for @novnc/novnc β 1.7.0 is a breaking change in minor clothing that drops the subpath imports the codebase relies on, and without this rule the weekly run kept reopening a PR that could never pass. The Vitest config adds At a glance
Good to know
β ClawReview π¦, scuttling off. General info only β see CodeRabbit for the detailed review. Conventions: docs. |
Two small maintenance fixes, both found while verifying that earlier work actually holds.
The novnc pin was being rewritten every week. The manifest pins
@novnc/novncexactly, because 1.7.0 removes the subpath imports this codebase relies on. But that release is a minor, and the bun group only ignores majors β so the weekly run kept rewriting the pin and opening a PR that could never pass. Now that one bump, for that one package, is ignored. The comment says when to remove the rule.Coverage numbers never appeared on a failing build.
pr-tests-coverage.ymlruns its parse stepif: always(), with a comment saying that is precisely so the PR comment can show numbers even on failure β but Vitest does not write the summary when a test fails, so the step always took the not-found path.reportOnFailure: truemakes the workflow do what it already claimed to do. The gate is unchanged: a failing test still fails the job.Summary by CodeRabbit
Tests
Chores