refactor: shared useReconnect hook for the reconnect overlays (closes #191)

[KrasimirKralev]

Closes #191 — the deferred /simplify follow-up from #167/#168.

What

Four places had independently copy-pasted the same grace-timer → probe-loop → settle engine:

• WifiHandoffOverlay — cross-origin <img> probe → redirect to /setup
• CredentialsHandoffOverlay — same-origin HEAD (or <img>) probe → continue/redirect
• ReconnectingOverlay — health-endpoint poll → reload/redirect
• SettingsApp hostname-reboot effect — no-cors ping + hard-redirect fallback

They now share useReconnect({ probe, onReady, graceMs, intervalMs, readyDelayMs, hardTimeoutMs, enabled }). Callers supply only the reachability probe and the ready action; all timing, cancellation, and single-firing lives in the hook. Each overlay maps the hook’s grace | probing | ready phase onto its existing step UI.

Behavior

Pure refactor — no behavior change intended. The hook’s hardTimeoutMs fallback and once-fire guard preserve the SettingsApp reboot semantics (and turn its previously-possible double redirect into a single one).

Probe/onReady are held in refs so a parent re-render doesn’t restart the grace timer mid-handoff — the same pattern CredentialsHandoffOverlay already used for its onContinue.

Tests

• New unit coverage for the hook lifecycle: grace→probe→ready, disabled = idle, hard-timeout fallback, and unmount cancellation.
• WiFi handoff path stays covered by e2e (setup-wifi-handoff.spec.ts).
• On a real Jetson: tsc clean, 38/38 hook + component tests passing.

[coderabbitai]

Warning

Review limit reached

@KrasimirKralev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9219a7b0-3e76-4b7d-b76a-bcb11b5259fe

📥 Commits

Reviewing files that changed from the base of the PR and between 40f1210 and 923aa8d.

📒 Files selected for processing (6)

• src/components/CredentialsHandoffOverlay.tsx
• src/components/ReconnectingOverlay.tsx
• src/components/SettingsApp.tsx
• src/components/WifiHandoffOverlay.tsx
• src/hooks/useReconnect.ts
• src/tests/unit/use-reconnect.test.ts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🦀 ClawReview

Poked my eyestalks out for this one. Quick tour:

Pulls the duplicated grace-timer → probe-loop → settle engine out of four components (WifiHandoffOverlay, CredentialsHandoffOverlay, ReconnectingOverlay, and SettingsApp's hostname-reboot effect) into a single shared useReconnect hook. Callers now supply only a probe function and an onReady callback; all timing, cancellation, and once-fire logic lives in the hook. The PR is a pure refactor — no behavior changes intended — and ships with unit tests for the hook lifecycle.

At a glance

• ♻️ Refactor · touches setup wizard reconnect overlays + SettingsApp hostname-reboot flow
• Base branch: beta · +200 source / +107 tests across 6 files
• ✅ base beta matches the beta-first convention
• ✅ conventional PR title
• ✅ source changes come with test changes

Good to know

• ℹ️ New file src/hooks/useReconnect.ts is the single source of truth for the grace/probe/settle engine that runs on customer devices during WiFi handoff and device rename.
• ℹ️ As a side effect, the SettingsApp hostname-reboot path's previously-possible double redirect is closed — the once-fire guard in the hook prevents it.
• ℹ️ Unit tests included (4 cases: happy path, disabled/idle, hard-timeout fallback, unmount cancellation); WiFi handoff e2e coverage already existed.

_{— ClawReview 🦀, scuttling off. General info only — see CodeRabbit for the detailed review. Conventions: docs.}

[github-actions]

CI Summary

✅ Tests

• Result: passed
• View run
• Coverage: statements 70.78%, branches 61.07%, functions 66.6%, lines 72.7%

✅ E2E

• Result: passed
• View run

✅ E2E Install

• Result: success
• View run