Skip to content

fix: don't claim "Connected!" when a skill's config wasn't written - #181

Merged
KrasimirKralev merged 1 commit into
betafrom
fix/app-settings-honest-save
Jun 9, 2026
Merged

KrasimirKralev merged 1 commit into
betafrom
fix/app-settings-honest-save

Conversation

@KrasimirKralev

Copy link
Copy Markdown
Contributor

Problem

The installed-skill settings panel showed a green "Connected!" after Save for every skill β€” but apps/settings only has a config writer for home-assistant. For any other skill the entered keys land in preferences and never reach where the skill reads them, so "Connected!" implied the skill was wired up when it wasn't.

Fix

  • Gate the green "Connected!" on the backend's configWritten flag.
  • Otherwise show a neutral "Saved" plus a note that the skill's setup isn't wired yet β€” and that the input stays on the device and is never sent to the agent.

Context: the generic per-skill secret writer is blocked on ClawHub exposing a per-skill setup/required-keys schema (tracked in openclaw/clawhub#2570). This change just makes the current UI honest until that lands. The key-entry form itself already builds masked inputs from a skill's requiredEnv.

apps/settings only has a config writer for home-assistant, so for any
other skill the entered keys land in preferences but never reach where
the skill reads them. The save button showed "Connected!" regardless,
implying the skill was wired up when it wasn't. Gate the green
"Connected!" on the backend's configWritten flag; otherwise show a
neutral "Saved" plus a note that the skill's setup isn't wired yet (and
that the input never leaves the device).
@KrasimirKralev
KrasimirKralev requested a review from a team as a code owner June 9, 2026 08:59
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@KrasimirKralev, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 58 minutes and 35 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

βŒ› How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
βš™οΈ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 30039497-72af-408b-b4ce-75eeeb144e73

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 7f57229 and 55a7a4d.

πŸ“’ Files selected for processing (1)
  • src/components/InstalledAppSettings.tsx
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/app-settings-honest-save

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

CI Summary

βœ… Tests

  • Result: passed
  • View run
  • Coverage: statements 69.45%, branches 59.25%, functions 64.43%, lines 71.51%

βœ… E2E

βœ… E2E Install

@KrasimirKralev
KrasimirKralev merged commit 239ff51 into beta Jun 9, 2026
7 checks passed
@KrasimirKralev KrasimirKralev mentioned this pull request Jun 9, 2026
@KrasimirKralev
KrasimirKralev deleted the fix/app-settings-honest-save branch July 4, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant