fix: don't claim "Connected!" when a skill's config wasn't written - #181
Conversation
apps/settings only has a config writer for home-assistant, so for any other skill the entered keys land in preferences but never reach where the skill reads them. The save button showed "Connected!" regardless, implying the skill was wired up when it wasn't. Gate the green "Connected!" on the backend's configWritten flag; otherwise show a neutral "Saved" plus a note that the skill's setup isn't wired yet (and that the input never leaves the device).
|
Warning Review limit reached
More reviews will be available in 58 minutes and 35 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. β How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. π¦ How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. βΉοΈ Review infoβοΈ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: π Files selected for processing (1)
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The installed-skill settings panel showed a green "Connected!" after Save for every skill β but
apps/settingsonly has a config writer forhome-assistant. For any other skill the entered keys land in preferences and never reach where the skill reads them, so "Connected!" implied the skill was wired up when it wasn't.Fix
configWrittenflag.Context: the generic per-skill secret writer is blocked on ClawHub exposing a per-skill
setup/required-keys schema (tracked in openclaw/clawhub#2570). This change just makes the current UI honest until that lands. The key-entry form itself already builds masked inputs from a skill'srequiredEnv.