Show/hide the 'commit message' input in the git commit modal as appro…

…priate. Show for git repos, hide for LocalDirectory-type repos
ICRAR · Nov 4, 2024 · 7c2e2d2 · 7c2e2d2
1 parent a0cbd5b
commit 7c2e2d2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/Modals.ts b/src/Modals.ts
@@ -189,6 +189,9 @@ export class Modals {
             const repositories: Repository[] = Repositories.getList(repositoryService);
             $('#gitCommitModal').data('repositories', repositories);
             Utils.updateGitCommitRepositoriesList(repositories, null);
+
+            // show/hide commit message input based on whether the repositoryService is git-related or not
+            $('#gitCommitModalCommitMessageRow').toggle(Utils.repositoryServiceIsGit(repositoryService));
         });
 
         // #gitCustomRepositoryModal - requestUserAddCustomRepository()

diff --git a/src/Utils.ts b/src/Utils.ts
@@ -651,6 +651,13 @@ export class Utils {
 
         // validate fileName input
         Modals.validateCommitModalFileNameInputText();
+
+        // show/hide commit message input based on whether the repositoryService is git-related or not
+        $('#gitCommitModalCommitMessageRow').toggle(Utils.repositoryServiceIsGit(defaultRepositoryService));
+    }
+
+    static repositoryServiceIsGit(service: Repository.Service): boolean {
+        return service === Repository.Service.GitHub || service === Repository.Service.GitLab;
     }
 
     static requestUserEditField(eagle: Eagle, modalType: Eagle.ModalType, parameterType: Daliuge.FieldType, parameterUsage: Daliuge.FieldUsage, field: Field, choices: string[], callback: (completed: boolean, field: Field) => void) : void {

diff --git a/templates/modals.html b/templates/modals.html
@@ -198,7 +198,7 @@ <h5 class="modal-title" id="gitCommitModalTitle">Git Commit</h5>
                             </div>
                         </div>
                     </div>
-                    <div class="row">
+                    <div class="row" id="gitCommitModalCommitMessageRow">
                         <div class="col-3">
                             <p>Commit Message:</p>
                         </div>