Skip to content

Pushdown integer upcasts to scan #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: oss-main
Choose a base branch
from
Open

Pushdown integer upcasts to scan #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ option(VELOX_ENABLE_HIVE_CONNECTOR "Build Hive connector." ON)
option(VELOX_ENABLE_TPCH_CONNECTOR "Build TPC-H connector." ON)
option(VELOX_ENABLE_TPCDS_CONNECTOR "Build TPC-DS connector." ON)
option(VELOX_ENABLE_PRESTO_FUNCTIONS "Build Presto SQL functions." ON)
option(VELOX_ENABLE_SPARK_FUNCTIONS "Build Spark SQL functions." ON)
option(VELOX_ENABLE_SPARK_FUNCTIONS "Build Spark SQL functions." OFF)
option(VELOX_ENABLE_ICEBERG_FUNCTIONS "Build Iceberg functions." ON)
option(VELOX_ENABLE_EXPRESSION "Build expression." ON)
option(
Expand Down
9 changes: 9 additions & 0 deletions velox/core/Expressions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,15 @@ class FieldAccessTypedExpr : public ITypedExpr {
const std::string& name() const {
return name_;
}
//
// void setName(const std::string& newName) {
// name_ = newName;
// }
//
// void updateNewType(const std::string& newName, TypePtr newType) {
// name_ = newName;
// type_= newType;
// }

TypedExprPtr rewriteInputNames(
const std::unordered_map<std::string, TypedExprPtr>& mapping)
Expand Down
8 changes: 8 additions & 0 deletions velox/core/ITypedExpr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,18 @@ class ITypedExpr : public ISerializable {
ExprKind kind() const {
return kind_;
}
//
// virtual const std::string& name() const {
// VELOX_UNSUPPORTED("name() is not supported for this expression");
// }

const TypePtr& type() const {
return type_;
}
//
// void setType(const TypePtr& newType) {
// type_.reset(newType.get());
// }

const std::vector<TypedExprPtr>& inputs() const {
return inputs_;
Expand Down
Loading