Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated check tool to use helm 3 linting after PR is merged #298

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

bitscuit
Copy link
Member

@bitscuit bitscuit commented Feb 8, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @morvencao

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@bitscuit
Copy link
Member Author

bitscuit commented Feb 8, 2021

/cc @horis233

@ibm-ci-bot ibm-ci-bot requested a review from horis233 February 8, 2021 22:36
Copy link

@horis233 horis233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitscuit, horis233

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 92c3db8 into IBM:master Feb 9, 2021
@ibm-ci-bot
Copy link
Collaborator

@bitscuit: Updated the job-config configmap in namespace default using the following files:

  • key IBM.ibm-platform-api-operator.master.yaml using file prow/cluster/jobs/IBM/ibm-platform-api-operator/IBM.ibm-platform-api-operator.master.yaml

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @morvencao

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants