update build-tool image #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvencao
reviewed
Jan 21, 2021
There was a problem hiding this comment.
/lgtm
/approve
/hold
@horis233 Not sure how kubernetes/test-infra uses the bot to automatically bump up the new image version, see: kubernetes#20537
You can take a look how it is implemented if you have bandwidth.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: horis233, morvencao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks good to me, feel free to remove |
|
@morvencao Thanks for the information and your review. I will take a look at it afterwards. |
|
@horis233: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
horis233
added a commit
to horis233/test-infra
that referenced
this pull request
Jan 22, 2021
This reverts commit 494048c.
horis233
added a commit
that referenced
this pull request
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR update the build-tool image for common service jobs.
The main change is to update the go version from 1.14.7 to 1.15.6
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Specify your PR reviewers:
/cc @gyliu513 @morvencao
Special notes for your reviewer:
Release note: