Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new reviewers and approvers. #253

Merged
merged 2 commits into from
Oct 21, 2020
Merged

add new reviewers and approvers. #253

merged 2 commits into from
Oct 21, 2020

Conversation

morvencao
Copy link

What this PR does / why we need it:
add @ashank07 and @xcliu-ca to the reviewer and approver list.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @morvencao

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@ibm-ci-bot ibm-ci-bot requested a review from gyliu513 October 21, 2020 13:01
@ibm-ci-bot
Copy link
Collaborator

@morvencao: GitHub didn't allow me to request PR reviews from the following users: morvencao.

Note that only IBM members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:
add @ashank07 and @xcliu-ca to the reviewer and approver list.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @morvencao

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: morvencao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@morvencao morvencao added the lgtm label Oct 21, 2020
@ibm-ci-bot ibm-ci-bot merged commit 4b8ffec into master Oct 21, 2020
@morvencao morvencao deleted the br_update_owner_file branch October 21, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants