Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow development jobs #242

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Allow development jobs #242

merged 3 commits into from
Sep 29, 2020

Conversation

adamdyszy
Copy link

What this PR does / why we need it:

This allows our team to push changes not only to master, for example when master is freezed and we want to have separate jobs with same checks but different pushes

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @morvencao

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


Copy link

@morvencao morvencao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add prow job in a separate file? As you can see from file name, it's for master branch.

@ibm-ci-bot ibm-ci-bot added size/L and removed size/M labels Sep 29, 2020
@adamdyszy
Copy link
Author

@morvencao did as you asked

Copy link

@morvencao morvencao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamdyszy, morvencao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 64d4ee7 into IBM:master Sep 29, 2020
@ibm-ci-bot
Copy link
Collaborator

@adamdyszy: Updated the job-config configmap in namespace default using the following files:

  • key IBM.ibm-licensing-operator.development.yaml using file prow/cluster/jobs/IBM/ibm-licensing-operator/IBM.ibm-licensing-operator.development.yaml

In response to this:

What this PR does / why we need it:

This allows our team to push changes not only to master, for example when master is freezed and we want to have separate jobs with same checks but different pushes

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @morvencao

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants