Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update post submit container #217

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

sgrube
Copy link
Member

@sgrube sgrube commented Aug 14, 2020

What this PR does / why we need it:
Missed edit on my part - need to get to go 1.14

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @morvencao

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@kuanf
Copy link

kuanf commented Aug 14, 2020

given the change is only for metering, I'm trying to help during NA day time.

@kuanf
Copy link

kuanf commented Aug 14, 2020

/lgtm

@ibm-ci-bot
Copy link
Collaborator

@kuanf: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@morvencao morvencao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: morvencao, sgrube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 74a0207 into IBM:master Aug 15, 2020
@ibm-ci-bot
Copy link
Collaborator

@sgrube: Updated the job-config configmap in namespace default using the following files:

  • key IBM.ibm-metering-operator.master.yaml using file prow/cluster/jobs/IBM/ibm-metering-operator/IBM.ibm-metering-operator.master.yaml

In response to this:

What this PR does / why we need it:
Missed edit on my part - need to get to go 1.14

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Specify your PR reviewers:

/cc @gyliu513 @morvencao

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants