Skip to content

chore(deps): update dependency golangci/golangci-lint to v2.6.2 #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dnwe merged 2 commits into from
Nov 27, 2025
Merged

chore(deps): update dependency golangci/golangci-lint to v2.6.2 #3366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
418183b
chore(deps): update dependency golangci/golangci-lint to v2.6.2
renovate[bot] Nov 14, 2025
2ef85df
fix: correct new golangci-lint warnings
dnwe Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ env:
# Use the Go toolchain installed by setup-go
GOTOOLCHAIN: local
# renovate: datasource=github-releases depName=golangci/golangci-lint
GOLANGCI_LINT_VERSION: v2.5.0
GOLANGCI_LINT_VERSION: v2.6.2
# renovate: datasource=github-releases depName=dominikh/go-tools
STATICCHECK_VERSION: 2025.1.1
# renovate: datasource=github-releases depName=mfridman/tparse
Expand Down
1 change: 1 addition & 0 deletions admin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ type ClusterAdmin interface {
// This operation is not transactional so it may succeed or fail.
// If you attempt to add an ACL that duplicates an existing ACL, no error will be raised, but
// no changes will be made. This operation is supported by brokers with version 0.11.0.0 or higher.
//
// Deprecated: Use CreateACLs instead.
CreateACL(resource Resource, acl Acl) error

Expand Down
2 changes: 1 addition & 1 deletion client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ func TestClientRefreshBrokers(t *testing.T) {
newSeedBrokers := []string{"localhost:12345"}
_ = client.RefreshBrokers(newSeedBrokers)

if client.seedBrokers[0].addr != newSeedBrokers[0] {
if len(client.seedBrokers) == 0 || client.seedBrokers[0].addr != newSeedBrokers[0] {
t.Error("Seed broker not updated")
}
if len(client.Brokers()) != 0 {
Expand Down
1 change: 1 addition & 0 deletions config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ type Config struct {
}
Rebalance struct {
// Strategy for allocating topic partitions to members.
//
// Deprecated: Strategy exists for historical compatibility
// and should not be used. Please use GroupStrategies.
Strategy BalanceStrategy
Expand Down
Loading