Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kafka 3.0.0 #2034

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Add support for kafka 3.0.0 #2034

merged 1 commit into from
Sep 20, 2021

Conversation

bai
Copy link
Contributor

@bai bai commented Sep 20, 2021

@bai bai force-pushed the kafka-3 branch 2 times, most recently from 71e6a7a to 236916c Compare September 20, 2021 12:44
@bai bai mentioned this pull request Sep 20, 2021
@dnwe
Copy link
Collaborator

dnwe commented Sep 20, 2021

I was just about to say, I can't see a 6.2.1 tag on docker.io :)

@dnwe
Copy link
Collaborator

dnwe commented Sep 20, 2021

Aside: should we have constants for V2_7_0_1 and V2_8_0_1 ?

@bai
Copy link
Contributor Author

bai commented Sep 20, 2021

Great question: do we want to add constants for all minor versions? This is the hack I'm doing in Burrow to get around this, for instance: https://github.com/linkedin/Burrow/blob/master/core/internal/helpers/sarama.go#L26-L70

@dnwe
Copy link
Collaborator

dnwe commented Sep 20, 2021

If/when we move to using ApiVersionsResponse results to gate protocol, I guess we wouldn't necessarily have these constants anymore

@dnwe
Copy link
Collaborator

dnwe commented Sep 20, 2021

Not sure why the pull of ghcr.io/shopify/toxiproxy:2.1.5 is periodically getting unauthenticated errors in your CI runs. It clearly works most of the time without auth, so not sure what's broken

EDIT: ah 503 Service Unavailable on the last run, I'm guessing ghcr.io is just having problems atm

@dnwe dnwe merged commit 94c8136 into main Sep 20, 2021
@dnwe dnwe deleted the kafka-3 branch September 20, 2021 23:15
dnwe added a commit that referenced this pull request Sep 20, 2021
As discussed under #2034, should simplify linkedin/Burrow usage too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants