Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes deletion of the filesets to non-force #1239

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

badri-pathak
Copy link
Member

@badri-pathak badri-pathak commented Oct 15, 2024

Signed-off-by: badri-pathak [email protected]

Pull request checklist


Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature Enhancement
  • Test Automation
  • Code Refactoring (no functional changes, no api changes)
  • Build related changes
  • Community Operator listing
  • Other (please describe):

What is the current behavior?

  • The delete filesets are called without any safe mode i.e. force as true.

What is the new behavior?

  • The delete filesets will be called with safe mode as True i.e. force as false.

"commands" : [ "mmunlinkfileset 'fs1' 'pvc-a3d919f8-6a36-4781-b9a8-b0554038c78e' -f ", "mmdelfileset 'fs1' 'pvc-a3d919f8-6a36-4781-b9a8-b0554038c78e' --qos 'maintenance' " ],

How risky is this change?

  • Small, isolated change
  • Medium, requires regression testing
  • Large, requires functional and regression testing

@badri-pathak
Copy link
Member Author

Image : quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:fsetDelNonForce_v2

@badri-pathak
Copy link
Member Author

There is an external dependency for this PR. (EWM-338675) Delete fileset GUI API doesn't provide an option to configure force unlink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant