retry parsing after removing the cache file. #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 17, 2023 10:46
Signed-off-by: Rahman Abber Tahir <[email protected]>
Signed-off-by: Rahman Abber Tahir <[email protected]>
Signed-off-by: Rahman Abber Tahir <[email protected]>
rainerschoe
reviewed
Nov 20, 2023
Comment on lines
331
to
334
| localDescDb::DescriptorDb newDbFile; //new file to ensure there are no side-effects from last parsing failure. | ||
| std::filesystem::remove(cacheFilePath); //remove cache file if failed and try again. | ||
|
|
||
| if( getDbFileFromCacheFile(cacheFilePath, newDbFile) == false ) |
There was a problem hiding this comment.
Suggested change
| localDescDb::DescriptorDb newDbFile; //new file to ensure there are no side-effects from last parsing failure. | |
| std::filesystem::remove(cacheFilePath); //remove cache file if failed and try again. | |
| if( getDbFileFromCacheFile(cacheFilePath, newDbFile) == false ) | |
| // Parsing the cache file failed. re-instantiating the cache: | |
| // remove cache file if failed and try again. | |
| std::filesystem::remove(cacheFilePath); | |
| // new file to ensure there are no side-effects from last parsing failure. | |
| localDescDb::DescriptorDb newDbFile; | |
| if( getDbFileFromCacheFile(cacheFilePath, newDbFile) == false ) |
There was a problem hiding this comment.
ah the comments and arrangment... done
| { | ||
| std::string cacheFilePath = prepareCacheFile(); | ||
|
|
||
| static bool getDbFileFromCacheFile(const std::string& cacheFilePath, localDescDb::DescriptorDb& file) |
There was a problem hiding this comment.
Suggested change
| static bool getDbFileFromCacheFile(const std::string& cacheFilePath, localDescDb::DescriptorDb& file) | |
| /// returns false if file was found but could not be parsed. true otherwise. | |
| static bool getDbFileFromCacheFile(const std::string& cacheFilePath, localDescDb::DescriptorDb& file) |
| @@ -42,6 +42,28 @@ RPC succeeded :D | |||
| #END_CMD | |||
| #END_TEST | |||
|
|
|||
| #START_TEST RPC with invalid cache | |||
There was a problem hiding this comment.
Thanks for adding this test :)
Signed-off-by: Rahman Abber Tahir <[email protected]>
Thanks for reviews :) added some comments/styling as suggested, pls have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.