Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path issues when running superworkflow pipeline sample for kfp v2 #935

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

revit13
Copy link
Collaborator

@revit13 revit13 commented Jan 13, 2025

Why are these changes needed?

Currently the path to kfp component specifications files in the python workflow file is hard coded.
This causes an error when compiling super pipeline v2 reported in issue #909
To avoid this. the path is saved in an env variable with a default value.

Related issue number (if any).

#909

@revit13 revit13 marked this pull request as draft January 13, 2025 04:31
Signed-off-by: Revital Sur <[email protected]>
@revit13 revit13 marked this pull request as ready for review January 13, 2025 07:38
Copy link
Member

@roytman roytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q. should we use ../../../../kfp/kfp_ray_components/ as a shared constant?

Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
@revit13
Copy link
Collaborator Author

revit13 commented Jan 13, 2025

Q. should we use ../../../../kfp/kfp_ray_components/ as a shared constant?

Done. Thanks

Copy link
Member

@roytman roytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@revit13 revit13 merged commit ae2575f into IBM:dev Jan 14, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants