Update all transforms to use single package library with [extra] #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
…nd move to dev2 Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
touma-I
commented
Oct 24, 2024
touma-I
commented
Oct 24, 2024
Added missing requirements.txt
Add missing file name argument
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
…h hap kfp Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
|
LGTM |
|
Minor comment: Please consider renaming |
revit13
approved these changes
Oct 25, 2024
Signed-off-by: Maroun Touma <[email protected]>
daw3rd
reviewed
Oct 28, 2024
| @@ -29,7 +29,7 @@ publish:: publish-dist | |||
|
|
|||
| publish-dist :: .check-env .defaults.publish-dist | |||
|
|
|||
| venv:: pyproject.toml | |||
There was a problem hiding this comment.
should this now depend on requirements.txt
daw3rd
reviewed
Oct 28, 2024
| @@ -27,15 +27,16 @@ publish:: publish-dist | |||
|
|
|||
| publish-dist :: .check-env .defaults.publish-dist | |||
|
|
|||
| venv:: pyproject.toml | |||
Thanks @revit13 Good catch! Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Remove pyproject.toml for both ray and python and update makefiles and dependencies
Related issue number (if any).