Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #714

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Update README.md #714

merged 3 commits into from
Oct 18, 2024

Conversation

pankajskku
Copy link
Member

Why are these changes needed?

Typo

Related issue number (if any).

Signed-off-by: Pankaj Thorat <[email protected]>
@pankajskku
Copy link
Member Author

@touma-I There was a typo in README.

@touma-I touma-I self-requested a review October 16, 2024 12:40
@touma-I
Copy link
Collaborator

touma-I commented Oct 16, 2024

@shahrokhDaijavad We are adding a new transform for the code profiler. This work was discussed at the tech talk last week and consists of 2 components. Right now, we only have the first component for the sytactic concept extractor and will be adding the other component in a second PR. Can you please review the short writeup on the first component ? The code has already been merged but I think having you review the Readme will give you awareness and also
provide more input on how/what we are doing? Thanks

@shahrokhDaijavad
Copy link
Member

Very interesting transform! Please see the suggested revisions is text.

I wanted "an unified" to be changed to "a unified," not the other way around!
Copy link
Member

@shahrokhDaijavad shahrokhDaijavad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @pankajskku.

@touma-I touma-I merged commit c7c3bca into IBM:dev Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants