-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release documentation and notes #624
Conversation
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for some gramatical comments that you can choose to ignore. :-)
RELEASE.md
Outdated
@@ -3,7 +3,7 @@ | |||
## Overview | |||
Release are created from the main repository branch using the version | |||
numbers, including an intermediate version suffix, | |||
defined in `.make.versions`. | |||
defined in `.make.versions` | |||
The following points are important: | |||
|
|||
1. In general, common a version number is used for all published pypi wheels and docker images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean: a common (it is written common a)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks.
RELEASE.md
Outdated
@@ -3,7 +3,7 @@ | |||
## Overview | |||
Release are created from the main repository branch using the version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that read "Release is" or "Releases are" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks.
@@ -20,29 +20,35 @@ allows intermediate publishing from the main branch using version X.Y.Z.dev\<N\> | |||
## Cutting the release | |||
Creating the release involves | |||
|
|||
1. Edit the `release-notes.md` to list major/minor changes | |||
1. Creating a release branch and tag and updating the main branch versions. | |||
1. Creating a github release from the release branch and tag. | |||
1. Building and publishing pypi library wheels and docker registry image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this missing the step for creating a new dev branch that increments the release number ?
Also should we use Create a ..., Build and publish... similar to first bullet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think that is covered in 2 ...and updating the main branch versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daw3rd There are a couple. of comments related to grammar. We can merge with or without. Let me know. Thanks
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Why are these changes needed?
Updates to release documentation
Add release notes for 0.2.1 release
Related issue number (if any).