Fix make set-versions target #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
roytman
reviewed
Aug 28, 2024
.make.defaults
Outdated
| -e 's/"data-prep-toolkit\([=><][=><]\).*",/"data-prep-toolkit\1$(DPK_LIB_VERSION)",/' \ | ||
| -e 's/"ray\[default\]\([=><][=><]\).*",/"ray\[default\]\1$(RAY)",/' \ | ||
| -e 's/"data-prep-toolkit-kfp-shared\(..\).*",/"data-prep-toolkit-kfp-shared\1$(DPK_LIB_KFP_VERSION)",/' \ | ||
| -e 's/"data-prep-toolkit-ray\([=><][=><]\).*"/"data-prep-toolkit-ray\1$(DPK_LIB_VERSION)"/' \ |
There was a problem hiding this comment.
if you want to narrow possible options, I'd define it as `[=><~][=].
transforms/.make.transforms
Outdated
| @@ -335,8 +335,9 @@ minio-stop: | |||
| if [ -e pyproject.toml ]; then \ | |||
| dash_name=$$(echo $(TRANSFORM_NAME) | sed -e 's/_/-/g'); \ | |||
| cat pyproject.toml | sed \ | |||
| -e 's/"dpk-$(TRANSFORM_NAME)-transform-python\([=<>][=<>]\).*",/"dpk-$(TRANSFORM_NAME)-transform-python\1$(TRANSFORM_PYTHON_VERSION)",/' \ | |||
| -e 's/"dpk-'$${dash_name}'-transform-python\([=<>][=<>]\).*",/"dpk-'$${dash_name}'-transform-python\1$(TRANSFORM_PYTHON_VERSION)",/' \ | |||
| -e 's/"dpk_$(TRANSFORM_NAME)_transform_python\([=<>][=<>]\).*"/"dpk_$(TRANSFORM_NAME)_transform_python\1$(TRANSFORM_PYTHON_VERSION)"/' \ | |||
There was a problem hiding this comment.
why not rename ones all dpk-...-transform-pyton ?
Signed-off-by: David Wood <[email protected]>
roytman
approved these changes
Aug 28, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Update .make.defaults and .make.transforms to address issues found in #541
Related issue number (if any).