Super pipeline KFPv2. #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Nassar <[email protected]>
Signed-off-by: Mohammad Nassar <[email protected]>
Signed-off-by: Mohammad Nassar <[email protected]>
revit13
reviewed
Aug 11, 2024
Signed-off-by: Mohammad Nassar <[email protected]>
revit13
reviewed
Aug 11, 2024
revit13
reviewed
Aug 11, 2024
revit13
reviewed
Aug 11, 2024
Signed-off-by: Mohammad Nassar <[email protected]>
Signed-off-by: Mohammad Nassar <[email protected]>
Signed-off-by: Mohammad Nassar <[email protected]>
Signed-off-by: Mohammad Nassar <[email protected]>
revit13
approved these changes
Aug 12, 2024
roytman
reviewed
Aug 12, 2024
| - It is not required to upload the transforms pipelines before running the superpipeline. | ||
| - It created just one run that includes all the nested transfroms and their sub-tasks. | ||
| - No need for additional component as `executeSubWorkflowComponent.yaml`. All the implementation in the same pipeline file. | ||
| - One missing thing in this implementation is the overriding parameters option. |
There was a problem hiding this comment.
From here it is not clear what do you mean
There was a problem hiding this comment.
Is this sentence better:
In superpipelines of KFP v1 there exists an option to override the common parameters with specific values for each one of the transforms. This option is missing in the KFP v2 superpipelines.
|  | ||
|
|
||
| ## Main differences from KFP v1 superpipeline: | ||
| - It is not required to upload the transforms pipelines before running the superpipeline. |
There was a problem hiding this comment.
maybe to add that the entire pipeline and the nested pipelines are up to date.
Signed-off-by: Mohammad Nassar <[email protected]>
roytman
approved these changes
Aug 19, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number (if any).