Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix path in notebook #446

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix path in notebook #446

merged 1 commit into from
Jul 25, 2024

Conversation

shivdeep-singh-ibm
Copy link
Collaborator

@shivdeep-singh-ibm shivdeep-singh-ibm commented Jul 25, 2024 •
edited
Loading

Why are these changes needed?

since notebook has moved into folder, we need to update paths of lang_extensions.json wrt new notebook path

Related issue number (if any).

@shivdeep-singh-ibm
fix path in notebook
78e1a8b 
Signed-off-by: Shivdeep Singh <[email protected]>
@shivdeep-singh-ibm shivdeep-singh-ibm mentioned this pull request Jul 25, 2024
Closed
2 tasks
shahrokhDaijavad
shahrokhDaijavad approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@shahrokhDaijavad shahrokhDaijavad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did test this by going through all cells of the Notebook.

@shahrokhDaijavad shahrokhDaijavad merged commit 45d66ec into IBM:dev Jul 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahrokhDaijavad shahrokhDaijavad shahrokhDaijavad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivdeep-singh-ibm @shahrokhDaijavad