Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get config parameter function. #427

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Fix get config parameter function. #427

merged 2 commits into from
Jul 23, 2024

Conversation

Mohammad-nassar10
Copy link
Collaborator

@Mohammad-nassar10 Mohammad-nassar10 commented Jul 21, 2024

Why are these changes needed?

Fixing a bug in getting the config parameter. Fixed according to @yuanchi2807 suggestion.

Related issue number (if any).

Fixes #425

Signed-off-by: Mohammad Nassar <[email protected]>
Copy link
Contributor

@yuanchi2807 yuanchi2807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIth the change, there will not be side effects elsewhere I hope.

@blublinsky
Copy link
Collaborator

@yuanchi2807 none whatsoever

Signed-off-by: Mohammad Nassar <[email protected]>
@daw3rd daw3rd merged commit 76e3d9a into dev Jul 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] get_config_parameter returns without checking if the config value exists
4 participants