update the kfp release process #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daw3rd
reviewed
Jun 25, 2024
kfp/kfp_ray_components/Makefile
Outdated
| $(MAKE) set-versions | ||
| $(MAKE) .lib-src-image | ||
|
|
||
|
|
||
| .PHONY: .reconcile-requirements | ||
| .reconcile-requirements: | ||
| @$(make) .setImage |
There was a problem hiding this comment.
Is there a diff between $(make) and $(MAKE)?
Mohammad-nassar10
approved these changes
Jun 26, 2024
revit13
reviewed
Jun 26, 2024
kfp/kfp_ray_components/Makefile
Outdated
| @$(make) build | ||
| $(MAKE) .defaults.publish-image | ||
| ifeq ($(CURRENT_KFPv2), 1) | ||
| export KFPv2=CURRENT_KFPv2 |
There was a problem hiding this comment.
mabye run set-versions again here
revit13
approved these changes
Jun 26, 2024
roytman
force-pushed
the
releasing2
branch
2 times, most recently
from
c297f87
to
70fdac7
Compare
Signed-off-by: Alexey Roytman <[email protected]>
Signed-off-by: Mohammad Nassar <[email protected]>
Signed-off-by: Alexey Roytman <[email protected]>
Signed-off-by: Alexey Roytman <[email protected]>
daw3rd
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Update the KFP publishing process. We have to publish 2 different images: one for KFPv1 and another for KFPv2.
Note: this PR is instead of #335