Updated generate (simple pipeline) pipeline #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roytman
reviewed
Jun 21, 2024
kfp/pipeline_generator/run.sh
Outdated
| @@ -8,4 +8,6 @@ mkdir -p ${ROOT_DIR}/${DIST_DIR}/ | |||
| python3 -m venv venv | |||
| source venv/bin/activate | |||
| pip install pre-commit | |||
| python3 pipeline_generator.py -c ${DEF_FILE} -od ${ROOT_DIR}/${DIST_DIR}/ | |||
| pip install jinja2 | |||
| # python3 pipeline_generator.py -c ${DEF_FILE} -od ${ROOT_DIR}/${DIST_DIR}/ | |||
roytman
reviewed
Jun 21, 2024
|
|
||
| # define arguments to the Ray execution job | ||
| execute_job_params = get_execute_job_params_guf(pipeline_definitions[PIPELINE_TRANSFORM_INPUT_PARAMETERS]) | ||
| pipeline_transform_input_parameters = pipeline_definitions[PIPELINE_TRANSFORM_INPUT_PARAMETERS] | ||
|
|
||
| component_spec_path = pipeline_parameters.get("component_spec_path", "") | ||
| if component_spec_path == "": | ||
| component_spec_path = "../../../../../kfp/kfp_ray_components/" |
There was a problem hiding this comment.
it can be wrong, usually in the DataPrep-Kit project, the Ray components are in "../../../../kfp/kfp_ray_components/".
| ComponentUtils.set_s3_env_vars_to_component(execute_job, data_s3_access_secret) | ||
| execute_job.after(ray_cluster) | ||
| # Configure the pipeline level to one week (in seconds) | ||
| # dsl.get_pipeline_conf().set_timeout(ONE_WEEK_SEC) |
There was a problem hiding this comment.
please remove these two commented out lines
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Updated simple pipeline generator to match current simple pipeline spec (which now supports KFP v2). Running instructions are same as the running instructions for previous pipeline generator.
Related issue number (if any).