Ray version update #305
Merged
Ray version update #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revit13
approved these changes
Jun 20, 2024
roytman
reviewed
Jun 20, 2024
| @@ -52,6 +51,8 @@ venv:: pyproject.toml .check-env | |||
| pip install --upgrade pip; \ | |||
| cd ../../../data-processing-lib/python && make set-versions && cd -; \ | |||
| pip install -e ../../../data-processing-lib/python; \ | |||
| cd ../../../data-processing-lib/ray && make set-versions && cd -; \ | |||
| pip install -e ../../../data-processing-lib/ray; \ | |||
There was a problem hiding this comment.
you don't want to set-versions there?
There was a problem hiding this comment.
version of what?
| @@ -1,4 +1,4 @@ | |||
| FROM docker.io/rayproject/ray:2.9.3-py310 | |||
| FROM docker.io/rayproject/ray:2.24.0-py310 | |||
There was a problem hiding this comment.
we need to add a make rule to set ray-based image and version
There was a problem hiding this comment.
You are welcome to do another PR once this one is merged. We actually discussed this with @revit13 when we were debugging this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Update Ray version to the current one
Related issue number (if any).