Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library versions update #186

Merged
merged 2 commits into from
May 24, 2024
Merged

library versions update #186

merged 2 commits into from
May 24, 2024

Conversation

blublinsky
Copy link
Collaborator

Why are these changes needed?

updated library/kfp image versions to 0.1.1 to capture the latest changes

Related issue number (if any).

@@ -23,5 +23,5 @@ CODE_QUALITY_VERSION=0.3.0
DOC_QUALITY_VERSION=0.3.0
INGEST_TO_PARQUET_VERSION=0.3.0

KFP_DOCKER_VERSION=0.2.0
KFP_DOCKER_VERSION=0.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you returned the major version back?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we are really on 0.1.1. Trying to be consistent

@@ -1,6 +1,6 @@
[project]
name = "data_prep_toolkit_kfp"
version = "0.1.0"
version = "0.1.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the version is wrong

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, its 0.1.1, which is correct

@@ -11,7 +11,7 @@ inputs:

implementation:
container:
image: quay.io/dataprep1/data-prep-kit/kfp-data-processing:0.2.0
image: quay.io/dataprep1/data-prep-kit/kfp-data-processing:0.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be 0.2.1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@roytman
Copy link
Member

roytman commented May 24, 2024

the pipelines should be updates as well

@blublinsky
Copy link
Collaborator Author

he pipelines should be updates as well

done

@blublinsky blublinsky merged commit 20520dd into dev May 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants