Add Process ID to formatters #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Honaker <[email protected]>
gabe-l-hart
requested changes
Oct 23, 2024
src/python/alog/alog.py
Outdated
| @@ -25,7 +25,7 @@ | |||
| logging package with a number of additional features, including log channels, | |||
| configurable formatting and scoped loggers. | |||
| """ | |||
|
|
|||
| import os | |||
There was a problem hiding this comment.
NIT: Please sort these alphabetically
src/python/alog/alog.py
Outdated
Comment on lines
553
to
555
| thread_id: bool =False, | ||
| handler_generator: Optional[Callable[[], logging.Handler]] = None, | ||
| process_id: bool =False, |
There was a problem hiding this comment.
Suggested change
| thread_id: bool =False, | |
| handler_generator: Optional[Callable[[], logging.Handler]] = None, | |
| process_id: bool =False, | |
| thread_id: bool = False, | |
| handler_generator: Optional[Callable[[], logging.Handler]] = None, | |
| process_id: bool = False, |
Signed-off-by: Michael Honaker <[email protected]>
gabe-l-hart
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Ok, nice! I think there are a few more things we should add to make this maximally useful:
- It should be handled in the pretty formatter. I'd suggest adding it right next to the
thread_id(here) so that it formats as:<thread_id>:P<proc_id> - We should add unit tests. This would look like adding it to the pretty print parsing, then replicating the tests for
thread_idand making sure we handle having both/one/neither.
|
@gabe-l-hart darn you trying to enforce good code etiquette. Let me push a commit |
Signed-off-by: Michael Honaker <[email protected]>
HonakerM
force-pushed
the
add_process_to_formatter
branch
from
b2542b3
to
04a4f9f
Compare
gabe-l-hart
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability for formatters to optionally include the process_id in the log message. This is useful for multi-process applications.
Changes
Add new option to python alog.configure.
Testing
Tested locally
Related Issue(s)
List any issues related to this PR