-
Notifications
You must be signed in to change notification settings - Fork 63
Enable multi-tenancy by via IBM AppID #87
base: master
Are you sure you want to change the base?
Conversation
@adrian555 May I ask if I should document steps of using AppID in |
@shawnzhu the way we did was to have the README.md in the current directory for the README.md in the upper directory to reference it. Thanks. |
kfctl apply -V -f kfctl_openshift_tekton_kfserving_appid.v1.1.0.yaml | ||
``` | ||
|
||
### Secure istio ingress gateway with HTTPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make this a step inside the Deploy Kubeflow with KfServing
heading? It seems that this section is required for such Kubeflow installation.
|
||
Notice that it uses HTTPS for the value of `oidcRedirectUrl` during configuration, which | ||
requires additional steps after deploying Kubeflow: | ||
1. enable [TLS passthrough](https://docs.openshift.com/enterprise/3.0/architecture/core_concepts/routes.html#passthrough-termination) mode for the route. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document link is pointing to OpenShift 3.0 link. Is there an equivalent link for at least 4.5+? Or is there a different approach in the later OpenShift releases to enable TLS passthrough?
Also, which route is the the route
referring to? May need to specify?
Notice that it uses HTTPS for the value of `oidcRedirectUrl` during configuration, which | ||
requires additional steps after deploying Kubeflow: | ||
1. enable [TLS passthrough](https://docs.openshift.com/enterprise/3.0/architecture/core_concepts/routes.html#passthrough-termination) mode for the route. | ||
2. expose kubeflow dashboard over HTTPS by following steps of [this section](https://www.kubeflow.org/docs/ibm/deploy/authentication/#exposing-the-kubeflow-dashboard-with-dns-and-tls-termination). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link talks about setting the tls in the kubeflow-gateway, though the above enables the passthrough. It is not clear what exactly is required to set up with these two doc links.
kfctl apply -V -f kfctl_openshift_tekton_kfserving_appid.v1.1.0.yaml | ||
``` | ||
|
||
### Secure istio ingress gateway with HTTPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would help to have another heading, something like ### Log in to Kubeflow Dashboard with AppID
to provide the Kubeflow Dashboard link and the simple instructions how different users can log in to it with the AppID.
This is a follow up of IBM/manifests#6
Supports kubeflow/website#2182